Skip to content

Add hotkey navigation of the chat history in desktop#792

Merged
alex-mechler merged 4 commits into
masterfrom
scott_addChatHistory
Nov 19, 2020
Merged

Add hotkey navigation of the chat history in desktop#792
alex-mechler merged 4 commits into
masterfrom
scott_addChatHistory

Conversation

@deetergp

@deetergp deetergp commented Nov 13, 2020

Copy link
Copy Markdown
Contributor

This PR allows users to navigate their chat history using the History menu's Back ⌘+[ and Forward ⌘+] options.

cc @roryabraham @marcaaron

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/145143

Tests

  1. Launch the desktop app.
  2. View conversations between a few other users.
  3. Press CMD+[ till you get back to the first conversation.
  4. Press CMD+] till you get back to the last coversation.
  5. Do the same using the History > Forward & History > Backward menu options.

Screenshots

Screen Shot

2020-11-18_13-34-44 (1)

@deetergp deetergp requested a review from a team as a code owner November 13, 2020 00:08
@deetergp deetergp self-assigned this Nov 13, 2020
@botify botify requested review from stitesExpensify and removed request for a team November 13, 2020 00:08
@deetergp deetergp force-pushed the scott_addChatHistory branch from daab96c to a85ce69 Compare November 13, 2020 00:27
@deetergp deetergp removed the request for review from stitesExpensify November 13, 2020 00:33
@deetergp deetergp requested a review from a team November 18, 2020 21:49
@botify botify requested review from alex-mechler and removed request for a team November 18, 2020 21:49
@deetergp deetergp changed the title [WIP] Add hotkey navigation of the chat history in desktop Add hotkey navigation of the chat history in desktop Nov 18, 2020

@alex-mechler alex-mechler left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works like a charm :chefkiss:

@alex-mechler alex-mechler merged commit 3e9a132 into master Nov 19, 2020
@alex-mechler alex-mechler deleted the scott_addChatHistory branch November 19, 2020 01:23
elirangoshen added a commit to callstack-internal/Expensify-App that referenced this pull request May 28, 2026
…e98)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants